gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Change dependency from ctapipe to ctapipe-base #1247

Closed GernotMaier closed 2 days ago

GernotMaier commented 2 days ago

Closes #1246

ctapipe-base does not include optimal packages like matplotlib, bokeh, etc. (see https://ctapipe.readthedocs.io/en/stable/changelog.html#ctapipe-v0-23-0-2024-11-21)

ctao-dpps-sonarqube[bot] commented 2 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 2 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

tobiaskleiner commented 2 days ago

@GernotMaier as just discussed we have the dependency on CameraDisplay in plot_simtel_ctapipe in visualize.py, but this is not noticed since we have matplotlib dependency. So I guess we can switch to ctapipe-base.

GernotMaier commented 2 days ago

@tobiaskleiner - thank you!