search

gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Simulator configurator unecessary complicated and requires cross-module knowledge of data structures #911

Open GernotMaier opened 1 month ago

GernotMaier commented 1 month ago

The configuration of the Simulator tools through a yml file (e.g., ./tests/resources/prod_multi_config_test_North.yml) is unnecessary complicated.

The config dictionaries are modified in the applications (e.g., production.py or simulate_prod.py) and in Simulator in order to generate the right format for CorsikaRunner and SimtelRunner. High-level tools / modules need therefore to know exactly the data structure of the low level tools.

At several levels, there is a large number of modifications to the configuration dicts, including fine-tuned additions or pops. Very hard to maintain and we need to simplify this.

GernotMaier commented 1 month ago

Also requires a metaschema to validate the input configuration.