Closed GernotMaier closed 1 month ago
@VictorBarbosaMartins - please review only after #941 is merged to main (otherwise you review the same changes again)
I think we should talk to other groups in DPPS to check what is their approach in this regard. Perhaps repeating checks in the pre-commit hooks and ci linters is not a bad idea.
I think we should talk to other groups in DPPS to check what is their approach in this regard. Perhaps repeating checks in the pre-commit hooks and ci linters is not a bad idea.
Wait - pre-commit is running as linter in CI-linter over all files (this is also how DPPS is doing it). So we are still using all the tools and do a full linting.
Just to make the last point clearer: precommit is running over all files in Ci-linter.yml, see this line: https://github.com/gammasim/simtools/blob/6d10f5bf47956f9722d7a41062a223799944a9f7/.github/workflows/CI-linter.yml#L78
Thanks @VictorBarbosaMartins
Integrate ruff as linter and add it to pre-commit.
Cleanup of linters, see #942.
Pre-commit changes:
ruff format
as this introduces some changes)Github action changes:
Others
Closes #942.