search

gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Adding a new parameter to the database (even if not used) breaks code. #955

Closed GernotMaier closed 1 month ago

GernotMaier commented 1 month ago

Adding a new parameter to the database, even if not used, breaks the code, see e.g., the unit tests here.

In this case we have added an arrray_layouts parameter which is nowhere used in the current main branch.

This should be fixed and made more robust.

GernotMaier commented 1 month ago

Need to discuss if this is an issue or an feature: if new parameter is added to the DB and no schema file is available yet, simtools fails (e.g., the simulation software type is read from the schema files in names. get_simulation_software_name_from_parameter_name()).

That tests fail when adding an unused parameter is maybe annoying, but probably the best way to make sure that nothing unwanted is added.

I therefore suggest to define this as 'feature' and not as 'issue'. This means that we have to always add generate new databases when changing / adding parameters. This avoids conflicts with other branches (I usually do it; but thought it wouldn't be necessary in this case).

GernotMaier commented 1 month ago

I am closing this, as no worries are raised about the assumption that all parameter require schemas. So this is a feature.