search

gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Address issues reported by CTAO DPPS sonarqube #961

Closed GernotMaier closed 5 days ago

GernotMaier commented 1 month ago

PR #957 integrated simtools into CTAO DPPS sonarqube. Issues reported here should be addressed (or discussed, if it is something we are fine with).

GernotMaier commented 1 month ago

PR #969 reduces nicely the number of issues - see https://sonar-cta-dpps.zeuthen.desy.de/dashboard?id=gammasim_simtools_AY_ssha9WiFxsX-2oy_w

I've noticed that we do not run the unit tests after merging to main and therefore the sonarqu statistics on the project is not updated. Should we add running unit tests after merging?

Coverage dropped below the required 80% and we should check if this is mostly due to the missing unit tests in applications (see issue #972). Maybe we really should look into this add test for some of the functions in the applications.

GernotMaier commented 5 days ago

Screenshot 2024-07-10 at 08 48 44

Zero issues - this can be closed. Nice work, @tobiaskleiner