gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Improved naming of applications and get vs export #966

Closed GernotMaier closed 3 months ago

GernotMaier commented 3 months ago

PR to improve naming of applications and some functions.

Regarding issue #820: using find and grep, I was trying to find instances:

changed one 'add' to 'export in model/model_parameter.py

On make vs generate:

moved application make_regular_arrays.py go generate_regular_arrays

And while changing application names, several applications have been renamed to introduce a consistent and recognizable naming:

moved application produce_array_config.py to generate_array_config.py
moved applications for db to start with db_
moved applications for simulation to simulate_

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

0.70% Coverage (88.10% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

0.70% Coverage (88.10% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

0.70% Coverage (88.10% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

0.70% Coverage (88.10% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

1.80% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

1.80% Coverage (88.10% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

8.80% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

8.80% Coverage (87.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

8.80% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

8.80% Coverage (87.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

9.30% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

0 Bugs
0 Vulnerabilities
6 Code Smells

Coverage and Duplications

9.30% Coverage (87.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

75.20% Coverage on New Code (is less than 80.00%)

Analysis Details

22 Issues

0 Bugs
0 Vulnerabilities
22 Code Smells

Coverage and Duplications

75.20% Coverage (87.60% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

20.20% Coverage on New Code (is less than 80.00%)

Analysis Details

15 Issues

0 Bugs
0 Vulnerabilities
15 Code Smells

Coverage and Duplications

20.20% Coverage (85.40% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.40% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

0.40% Coverage (87.30% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Failed

0.40% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

0.40% Coverage (87.30% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube