gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Improve position coordinate transformation and add json reader / writer #968

Closed GernotMaier closed 4 months ago

GernotMaier commented 5 months ago

This PR adds a couple of improvements to the position coordinate transformations:

add possibility to do a coordinate conversion of single array element positions in the simtools-db-json format (application will understand the generic json format and write it also; see tests/integration_tests/config/convert_geo_coordinates_of_array_elements_ground_to_utm_json.yml
generalized the writing of simtools-db-json format-style files and move the function from simtel_config_reader to model_data_writer (simple move; no change in functionality
renamed application to convert coordinates (from misleading print_array_elements to convert_geo_coordinates_of_array_elements
improvement of docstrings to follow numpydoc standards

Add a small improvement to the integration tests to the function of compare_json_files: for simtools-db-type json files where a list of float is encoded as string (similar to sim_telarray; e.g., 5.5 3.2 7.6). Used np.all_close to compare those floats.

Closes #924

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

51.00% Coverage on New Code (is less than 80.00%)

Analysis Details

1 Issue

0 Bugs
0 Vulnerabilities
1 Code Smell

Coverage and Duplications

51.00% Coverage (92.80% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

51.00% Coverage on New Code (is less than 80.00%)

Analysis Details

1 Issue

0 Bugs
0 Vulnerabilities
1 Code Smell

Coverage and Duplications

51.00% Coverage (92.80% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

49.00% Coverage on New Code (is less than 80.00%)

Analysis Details

1 Issue

0 Bugs
0 Vulnerabilities
1 Code Smell

Coverage and Duplications

49.00% Coverage (91.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

72.80% Coverage on New Code (is less than 80.00%)

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

72.80% Coverage (92.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

61.20% Coverage on New Code (is less than 80.00%)

Analysis Details

4 Issues

0 Bugs
0 Vulnerabilities
4 Code Smells

Coverage and Duplications

61.20% Coverage (90.90% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

55.20% Coverage on New Code (is less than 80.00%)

Analysis Details

4 Issues

0 Bugs
0 Vulnerabilities
4 Code Smells

Coverage and Duplications

55.20% Coverage (90.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

55.60% Coverage on New Code (is less than 80.00%)

Analysis Details

4 Issues

0 Bugs
0 Vulnerabilities
4 Code Smells

Coverage and Duplications

55.60% Coverage (90.70% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

72.90% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

72.90% Coverage (92.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Passed

Analysis Details

18 Issues

0 Bugs
0 Vulnerabilities
18 Code Smells

Coverage and Duplications

91.90% Coverage (90.40% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 5 months ago

Failed

19.10% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

0 Bugs
0 Vulnerabilities
5 Code Smells

Coverage and Duplications

19.10% Coverage (86.90% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 months ago

Failed

72.80% Coverage on New Code (is less than 80.00%)

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

72.80% Coverage (91.80% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 months ago

Failed

72.80% Coverage on New Code (is less than 80.00%)

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

72.80% Coverage (91.80% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube