refactor complex functions

[ctao-dpps-sonarqube[bot]]

• 76.70% Coverage on New Code (is less than 80.00%)

Analysis Details

2 Issues

• 0 Bugs
• 0 Vulnerabilities
• 2 Code Smells

Coverage and Duplications

• 76.70% Coverage (93.60% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 71.90% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 71.90% Coverage (93.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 29.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 29.10% Coverage (92.50% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

• 0 Bugs
• 0 Vulnerabilities
• 5 Code Smells

Coverage and Duplications

• 37.30% Coverage (91.10% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 50.70% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

• 0 Bugs
• 0 Vulnerabilities
• 5 Code Smells

Coverage and Duplications

• 50.70% Coverage (91.10% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 52.90% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

• 0 Bugs
• 0 Vulnerabilities
• 5 Code Smells

Coverage and Duplications

• 52.90% Coverage (91.10% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 54.70% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

• 0 Bugs
• 0 Vulnerabilities
• 6 Code Smells

Coverage and Duplications

• 54.70% Coverage (91.10% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 52.40% Coverage on New Code (is less than 80.00%)

Analysis Details

7 Issues

• 0 Bugs
• 0 Vulnerabilities
• 7 Code Smells

Coverage and Duplications

• 52.40% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 16.30% Coverage on New Code (is less than 80.00%)

Analysis Details

9 Issues

• 0 Bugs
• 0 Vulnerabilities
• 9 Code Smells

Coverage and Duplications

• 16.30% Coverage (86.70% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 57.90% Coverage on New Code (is less than 80.00%)

Analysis Details

8 Issues

• 0 Bugs
• 0 Vulnerabilities
• 8 Code Smells

Coverage and Duplications

• 57.90% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 58.50% Coverage on New Code (is less than 80.00%)

Analysis Details

9 Issues

• 0 Bugs
• 0 Vulnerabilities
• 9 Code Smells

Coverage and Duplications

• 58.50% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 61.70% Coverage on New Code (is less than 80.00%)

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• 61.70% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 61.70% Coverage on New Code (is less than 80.00%)

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• 61.70% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 63.50% Coverage on New Code (is less than 80.00%)

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• 63.50% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 66.20% Coverage on New Code (is less than 80.00%)

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• 66.20% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 67.50% Coverage on New Code (is less than 80.00%)

Analysis Details

11 Issues

• 0 Bugs
• 0 Vulnerabilities
• 11 Code Smells

Coverage and Duplications

• 67.50% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 65.10% Coverage on New Code (is less than 80.00%)

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• 65.10% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 59.70% Coverage on New Code (is less than 80.00%)

Analysis Details

9 Issues

• 0 Bugs
• 0 Vulnerabilities
• 9 Code Smells

Coverage and Duplications

• 59.70% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 60.10% Coverage on New Code (is less than 80.00%)

Analysis Details

8 Issues

• 0 Bugs
• 0 Vulnerabilities
• 8 Code Smells

Coverage and Duplications

• 60.10% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 62.70% Coverage on New Code (is less than 80.00%)

Analysis Details

8 Issues

• 0 Bugs
• 0 Vulnerabilities
• 8 Code Smells

Coverage and Duplications

• 62.70% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 67.00% Coverage on New Code (is less than 80.00%)

Analysis Details

8 Issues

• 0 Bugs
• 0 Vulnerabilities
• 8 Code Smells

Coverage and Duplications

• 67.00% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 67.80% Coverage on New Code (is less than 80.00%)

Analysis Details

8 Issues

• 0 Bugs
• 0 Vulnerabilities
• 8 Code Smells

Coverage and Duplications

• 67.80% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 68.00% Coverage on New Code (is less than 80.00%)

Analysis Details

7 Issues

• 0 Bugs
• 0 Vulnerabilities
• 7 Code Smells

Coverage and Duplications

• 68.00% Coverage (91.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• B Reliability Rating on New Code (is worse than A)
• 67.40% Coverage on New Code (is less than 80.00%)

Analysis Details

7 Issues

• 1 Bug
• 0 Vulnerabilities
• 6 Code Smells

Coverage and Duplications

• 67.40% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• B Reliability Rating on New Code (is worse than A)
• 68.30% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

• 1 Bug
• 0 Vulnerabilities
• 5 Code Smells

Coverage and Duplications

• 68.30% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• B Reliability Rating on New Code (is worse than A)
• 69.60% Coverage on New Code (is less than 80.00%)

Analysis Details

5 Issues

• 1 Bug
• 0 Vulnerabilities
• 4 Code Smells

Coverage and Duplications

• 69.60% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• B Reliability Rating on New Code (is worse than A)
• 69.30% Coverage on New Code (is less than 80.00%)

Analysis Details

4 Issues

• 1 Bug
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.30% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.40% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.40% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.60% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.60% Coverage (91.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.60% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.60% Coverage (91.20% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.60% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.60% Coverage (90.50% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.50% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.50% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.30% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 69.10% Coverage on New Code (is less than 80.00%)

Analysis Details

3 Issues

• 0 Bugs
• 0 Vulnerabilities
• 3 Code Smells

Coverage and Duplications

• 69.10% Coverage (90.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[tobiaskleiner]

@GernotMaier thanks for the review. I have made the requested changes. Let me know if I can merge.

[GernotMaier]

Looks good - please merge. Thanks for this effort!