gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

Improved naming of simtel modules plus docstring ruff formatting. #976

Closed GernotMaier closed 1 month ago

GernotMaier commented 1 month ago

Do NOT review every single change in this PR. Review only the name changes of the modules in the simtools/simtel directory.

Improve naming of classes in simtel directory to have a clearer separation of those modules responsible for simulations and those for io. This is the change to review: are the new names good?

renaming done with search and replace
applied ruff check --fix to fix docstrings in simtel modules
applied trivial changes by hand (period at end of line. One-line docstring should fit on one line. 1 blank line required between summary line and description.

ctao-dpps-sonarqube[bot] commented 1 month ago

Passed

Analysis Details

16 Issues

0 Bugs
0 Vulnerabilities
16 Code Smells

Coverage and Duplications

94.10% Coverage (92.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 month ago

Passed

Analysis Details

16 Issues

0 Bugs
0 Vulnerabilities
16 Code Smells

Coverage and Duplications

94.10% Coverage (92.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube