search

gammasky / cta-dc

CTA data challenge 2017
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Clean up PWN scripts #7

Closed cdeil closed 7 years ago

cdeil commented 7 years ago

@robertazanin - Could you please clean up the 1DC PWN scripts? https://github.com/gammasky/cta-dc/tree/master/sky_model/pwn

There's sim_pwn.py and model_pwn.py which appear to be mostly the same. Is one of them an old version? Can you remove it?

Is the output ctadc_skymodel_gps_sources_pwn.ecsv in the repo up to date (i.e. the file produced currently by the script)?

The XML file doesn't parse, there's an opening spectrum tag and closing node tag:

<source name="pwn_0" type="ExtendedSource">
    <spectrum type="LogParabola">
        <parameter name="Prefactor" value="2.581e-19" unit="MeV-1 cm-2 s-1"/>
        <parameter name="Index" value="2.276" />
        <parameter name="Curvature" value="0.137"/>
        <parameter name="PivotEnergy" value="1000000.00000" unit="MeV"/>
      </node>

    <spatialModel type="RadialGaussian">
        <parameter name="GLON" value="14.93087" unit="deg"/>
        <parameter name="GLAT" value="-0.50759" unit="deg"/>
        <parameter name="Sigma" value="0.10118" unit="deg"/>
    </spatialModel>
 </source>

Can you please fix that?

I think some of the same comments you made for the bright sources in #6 apply here for the PWN XML file format, no?

cdeil commented 7 years ago

This issue is almost done.

The one remaining thing to to is to fix this issue https://github.com/gammapy/gammapy/issues/959 and to re-run (to have a reproducible version.

Re-assigning to me.

cdeil commented 7 years ago

Fixed in Gammapy. I'm not re-running the PWN script now, because Roberta is also modifying it at the moment.