gammastream / scully-plugins

A collection of plugins written for Scully
31 stars 9 forks source link

Error when installing via NPM #10

Closed etavener closed 4 years ago

etavener commented 4 years ago

I get the following error when I install your lib. It only recently started.

Error: Cannot find module 'fast-xml-parser'

msacket commented 4 years ago

I made a mistake in my npm package dependencies. I declared it as a devDependency instead of a peerDependency. At least I think that's the way it should be. The angular library complains if I declare it as simply a dependency. In any case, it is required. npm install --save-dev fast-xml-parser should get you going.

pegaltier commented 4 years ago

I got the same issue for two packages:

Indeed it works if i add the dependencies manually but please i would like to remove it when it will be fixed and added to peerDependency. Thanks

msacket commented 4 years ago

I believe I have this resolved by defining the proper peer dependencies in version 1.0.2. If I am mistaken, reopen this and I'll take another look.

peterpeterparker commented 3 years ago

just installed version 1.0.5 and same issue still seems to happen when running scully:

⠹ Error: Cannot find module 'fast-xml-parser'

msacket commented 3 years ago

fast-xml-parser is a peer dependency so you have to install it yourself. It should be telling you this when you install.

image

npm install --save-dev fast-xml-parser

peterpeterparker commented 3 years ago

oki doki thx for the feedback