gammata / TA-Unofficial-Patch-Install

the TA Unofficial patch that incorporates FunkyFr3sh's cncddraw implementation to make TA run smoothly on modern systems (Windows 10 and later)
32 stars 3 forks source link

Make patched TA runnable without admin #14

Open KevinHake opened 1 year ago

KevinHake commented 1 year ago

There's really no reason TA should need to run as admin, and given we have a lot of publicly released info on the exe, patches and netcode, it's not a good idea to let the game have full access to the system.

I'm not really sure why it ever started needing to run as admin, but also worth working with TA Forever as it has a "run as admin" option (default?) that ideally would also be removed.

KevinHake commented 1 year ago

Notes on crash dumps- Enabling user-mode dumps (crash reports) in Windows requires admin rights and might be part of why we run TA as admin (not sure if that's true, but the rest of this comment will run with the idea that it is). Each user could enable that manually (not ideal if we want consistent error reporting).

Could move setting the custom registry entry into a separate installer that runs as admin... but then we need an installer. Could also look into adding a custom crash handler (as a separate Issue) that would give us proper user-mode dumps without needing to set a registry entry for TA - some hints how:

gammata commented 1 year ago

Hi Kevin - I'm pretty sure I'm running TA without admin? It's certainly not a box ticked on the executable for me. Happy to discuss via chat on discord