search

gammazero / workerpool

Concurrency limiting goroutine pool
MIT License
1.33k stars 138 forks source link

addtion common function interface submit #32

Closed wbflooksky closed 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #32 into master will decrease coverage by 9.31%. The diff coverage is 48.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #32      +/-   ##
===========================================
- Coverage   100.00%   90.68%   -9.32%     
===========================================
  Files            2        2              
  Lines          132      161      +29     
===========================================
+ Hits           132      146      +14     
- Misses           0       13      +13     
- Partials         0        2       +2
Impacted Files Coverage Δ
workerpool.go 88.63% <48.27%> (-11.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c428e5...2822b24. Read the comment docs.

gammazero commented 4 years ago

I see the utility in CommonFunc and having a wrapper for it and Submit and SubmitWait, but these things so not beed to be part of the workerpool library in order to function. Therefore, I would prefer that such implementations remain separate. Users of workerpool can implement any variations of such functionality without needing to modify the underlying library.

For this reason I am deciding to close this PR. Thank you for your interest in contributing.