First of all, I feel that IceHRM is really awesome. Thanks a lot for the hardwork. I am new to IceHRM and just managed to play around with v8.4
However, I have discovered a minor problem on the "Available Leaves" for Leaves Entitlement tab whereby the value shown is always rounded. Example, the actual Available should be 10.5 but the value displayed is always 11.
I am not sure this is something overlooked or it is done intentionally. However, a minor tweak in "LeavesActionManager.php" solved the problem. I have removed the round for getEntitlement function on the available leaves and it seems to display the actual value now. Will there be any impact for the changes I have made?
gamonoid
commented
9 years ago
Original report by unity unity (Bitbucket: rouein, GitHub: rouein).
Hi,
First of all, I feel that IceHRM is really awesome. Thanks a lot for the hardwork. I am new to IceHRM and just managed to play around with v8.4
However, I have discovered a minor problem on the "Available Leaves" for Leaves Entitlement tab whereby the value shown is always rounded. Example, the actual Available should be 10.5 but the value displayed is always 11.
I am not sure this is something overlooked or it is done intentionally. However, a minor tweak in "LeavesActionManager.php" solved the problem. I have removed the round for getEntitlement function on the available leaves and it seems to display the actual value now. Will there be any impact for the changes I have made?