search

gamoteca / moodle-mod_gamoteca

Other
0 stars 1 forks source link

function naming violations #8

Closed danmarsden closed 7 months ago

danmarsden commented 2 years ago

https://github.com/gamoteca/gamoteca-moodle-lti-plugin/blob/master/lib.php#L179-L197

functions like "encrypt" or "unparse_url" are invalid. all functions in your plugin must be prefixed with the frankenstyle plugin name "modgamoteca" or in the case of activity module plugins the "mod" part can be excluded. Alternatively they can be in namespaced classes.

more info on this is here: https://moodledev.io/general/development/policies/codingstyle/frankenstyle

note this is a blocker for plugins db approval.

Tunyesz commented 2 years ago

Updated the function names in #9