search

gampleman / elm-example-publisher

Make a beautiful website from your Elm examples
MIT License
18 stars 2 forks source link

Allow for debug mode on example iframes #5

Open decioferreira opened 4 years ago

decioferreira commented 4 years ago

This change allows a very simple change on the example build, to allow for the examples to be compiled in debug mode.

gampleman commented 4 years ago

I've considered this before, but one of the reasons I'm a bit sceptical of this is that it will change the screenshots - they will now have the debug UI visible in them.

There is however an option in the screenshot producing library that allows you to hide a certain element before taking a screenshot, so perhaps we could use that? In that way the screenshots should look the same in debug mode as they do in normal operation.

decioferreira commented 4 years ago

I take your point. In my use case, I was only using the debug mode to review the messages and state on the examples I was building, so it was not a problem that the screenshots had the debugger element.