search

gandalf15 / HX711

Read HX711 ADC for Weigh Scales on Rasperry PIs.
BSD 3-Clause "New" or "Revised" License
114 stars 82 forks source link

correct True False return in reset() function #15

Closed adriencarbonaro closed 5 years ago

adriencarbonaro commented 5 years ago

You might prefer to return True when result returns something right ? Otherwise, it stop at the setup. There is still the GPIO.setmode() bug from #14 but that is out of topic for this

gandalf15 commented 5 years ago

I deliberately changed the behavior such that it returns true if it encounters error. If you look at the docstring it describes and explains the behavior. I also explained that the latest commit is not backward compatible with earlier versions. Thanks

adriencarbonaro commented 5 years ago

I did not see the changelog about backcompatibility ! I change the test so it wait for a false and it works.