DeleteDeadParticles - Githubissues

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)

GNU General Public License v2.0

46 stars 12 forks source link

DeleteDeadParticles #103

Closed rbooth200 closed 7 years ago

rbooth200 commented 8 years ago

There are currently some things about DeleteDeadParticles that are unsatisfactory:

We have two identical copies of the function
It invalidates the ghosts and we do not currently have a way to check that the ghosts are valid before using them.

The second problem could be solved pragmatically by just 'flagging' that the ghosts are invalid and checking this flag before walks are done. Alternatively it could be made valid. See the discussion here

giovanni-rosotti commented 7 years ago

The first problem is fixed in #128 . Do we have plans to fix the second one soon, or should we move the issue to a future milestone?

rbooth200 commented 7 years ago

I will have a think about the second one. There would still be a lot of places in which we need to check the tree's validity. The easiest solution would be to check the flags each (ghost) tree walk. It should be cheap, but its a lot of checks...

rbooth200 commented 7 years ago

Can we close this issue? DeleteDeadParticles invalidates the whole tree, not just the ghost particles so there is probably not much point in flagging anything.

rbooth200 commented 7 years ago

Bump

giovanni-rosotti commented 7 years ago

I agree it's fine to close this - closing