search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Changed dustybox to 1D #123

Open rbooth200 opened 7 years ago

rbooth200 commented 7 years ago

I've changed the dustybox test to be in 1D. While I accept that we do need some 3D tests, this one is very slow on travis. It's essentially a 0D problem, so 1D should be fine.

giovanni-rosotti commented 7 years ago

Then you need to update also the expected error of the test in nose...

rbooth200 commented 7 years ago

It's basically the same. I suppose I could add a test for both dust algorithms though...

rbooth200 commented 7 years ago

If you look at the errors it seems that there is a very small error (10^-9) in the hydro when running with MPI, which is causing the tests to fail. Any ideas?

dhubber commented 7 years ago

Is this pull request still needed or have the changes been merged elsewhere (since there have been other dust branches merged)?

rbooth200 commented 7 years ago

I never Merged these changes because this pull request highlights a likely small, but un fixed, bug with mpi

On Sat, 3 Jun 2017, 12:25 dhubber, notifications@github.com wrote:

Is this pull request still needed or have the changes been merged elsewhere (since there have been other dust branches merged)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/123#issuecomment-305966343, or mute the thread https://github.com/notifications/unsubscribe-auth/AOqItDcFC8GBb9D5fEC6VTgPsmEFgUaIks5sATSugaJpZM4LRAjE .