Uninitialised and unused variables

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)

GNU General Public License v2.0

44 stars 12 forks source link

Uninitialised and unused variables #136

Closed dhubber closed 7 years ago

dhubber commented 7 years ago

Newer version of previous uninitialised variables pull request. Cherry-picked from old branch onto newer up-to-date branch from master. In summary includes :

Removal of unused variables
Initialise any uninitialised variables to a sensible default value
Casting some unsigned ints to ints in conditional statments (N.B. used C-style casts)
Some code cleaning up, removal of old unused/out-of-date code
A few small optimisations (by way of using some intermediate const variables)

Also given the code another sweep for newly introduced unused/uninitialised variables. The only exceptions are the MultipleSourceIonisation.cpp and TreeRay.cpp files, which will be dealt with in a future pull request. Hopefully this can be merged quickly before it goes out-of-date (again) with the master branch.

giovanni-rosotti commented 7 years ago

For me it's fine. The previous pull request has introduced a conflict which I am going to take care of (and I will also get rid of some commented code).

giovanni-rosotti commented 7 years ago

Rebase done - wait for my commit now

rbooth200 commented 7 years ago

Assuming this passes travis, I'm happy for it to go.

giovanni-rosotti commented 7 years ago

Done. Richard, you should have the honour of merging the pull request as both David and I have been involved in the pull request.

dhubber commented 7 years ago

Ummmm, did you just close this branch without merging it Richard??

On 24 March 2017 at 21:04, Richard Booth notifications@github.com wrote:

Closed #136 https://github.com/gandalfcode/gandalf/pull/136.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/136#event-1014917601, or mute the thread https://github.com/notifications/unsubscribe-auth/AEsg1Zg6GdGzJ4XoNM7JDWWR4Thy-Ozcks5rpCHSgaJpZM4MoQ-H .

rbooth200 commented 7 years ago

Looks like it...

On 24/03/17 20:06, dhubber wrote:

Ummmm, did you just close this branch without merging it Richard??

On 24 March 2017 at 21:04, Richard Booth notifications@github.com wrote:

Closed #136 https://github.com/gandalfcode/gandalf/pull/136.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/136#event-1014917601, or mute the thread

https://github.com/notifications/unsubscribe-auth/AEsg1Zg6GdGzJ4XoNM7JDWWR4Thy-Ozcks5rpCHSgaJpZM4MoQ-H .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/136#issuecomment-289130167, or mute the thread https://github.com/notifications/unsubscribe-auth/AOqItHagbWY6L2kQjZMvvxr_fwvRz4vhks5rpCJSgaJpZM4MoQ-H.