gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Scott ionisation #142

Open dhubber opened 7 years ago

dhubber commented 7 years ago

Successfully merged Scott's ionisation algorithm with the latest version of the master branch. Compiles successfully both in serial and OpenMP (not checked MPI but actually the algorithm won't work at all in MPI anyway so perhaps that option should be disabled, i.e. throw an exception).

Important things to do before merging with master :

rbooth200 commented 7 years ago

Did you mean to add IC.cpp back in?

dhubber commented 7 years ago

Did you mean to add IC.cpp back in?

No, it was in the commit for Scott's algorithm (which is almost a year old now) and I didn't spot it. I'll get rid of it in the next commit.

dhubber commented 7 years ago

ok, I've fixed the main small issues with Scott's routine and it seems to run fine now. I've still to fully implement a solution in the python files that will allow an automatic nose/Travis run so this will be my aim in the next commit. But at least a direct comparison can be made with this and Jim's implementation in the meantime.