Paper revisions

[dhubber]

This branch is starting to get a little big so perhaps best to merge now/asap (even though there's still some more figures to be prepared for the paper). Most changes are due to

• Changed scripts for producing paper figures
• Minor bug fixes prepared while preparing figures (e.g. quadrupole moments)
• Additional IC class for IC-regularisation figure

I've already merged sink_nbody_update into this branch earlier so best to merge that one first I guess (assuming there are no objections in that branch).

[dhubber]

It was an experiment marrying Gradh and sinks more naturally rather than the current hacky way. Wasn't sure yet whether it was worth persevering so just left it for now (but zeroed/commented out so makes no difference)

On Fri 16. Jun 2017 at 21:39, giovanni-rosotti notifications@github.com wrote:

@giovanni-rosotti approved this pull request.

I am fine, I only have a very small thing!

In src/GradhSph/GradhSph.cpp https://github.com/gandalfcode/gandalf/pull/149#discussion_r122517515:

}

• rho_hmin = (FLOAT) 0.0;

I am confused. What is the point of the variable rho_hmin?

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/149#pullrequestreview-44646157, or mute the thread https://github.com/notifications/unsubscribe-auth/AEsg1esFd5dFvr7vgUD61SdFIBbdcdKNks5sEtnXgaJpZM4NvC-Q .

[giovanni-rosotti]

All right, who cares. I'll accept the pull request