search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Added missing paper tests #164

Closed rbooth200 closed 6 years ago

rbooth200 commented 6 years ago

I've added a couple of paper tests that were missing, we should probably include them.

giovanni-rosotti commented 6 years ago

So I've tried to run both python scripts and I can't (missing .dat files)... I guess you forgot to add the files in the commit?

giovanni-rosotti commented 6 years ago

dustywave says that the integration has failed (?)

rbooth200 commented 6 years ago

Works fine for me. More info?

giovanni-rosotti commented 6 years ago

ZVODE-- At current T (=R1), MXSTEP (=I1) steps taken on this call before reaching TOUT In above message, I1 = 500 In above message, R1 = 0.2917827165661D+01 /usr/local/lib/python2.7/site-packages/scipy/integrate/_ode.py:869: UserWarning: zvode: Excess work done on this call. (Perhaps wrong MF.) 'Unexpected istate=%s' % istate)) Traceback (most recent call last): File "dustywavetest.py", line 65, in sol = DustyWave(sim, t) File "../dust_tests/dustywave_sol.py", line 142, in DustyWave return solver(time)[0] File "../dust_tests/dustywave_sol.py", line 102, in call sol = self._solve_system(list(time)) File "../dust_tests/dustywave_sol.py", line 90, in _solve_system if not integ.successful(): raise RuntimeError('Integ failed') RuntimeError: Integ failed

On Wed, Oct 4, 2017 at 4:29 PM, Richard Booth notifications@github.com wrote:

Works fine for me. More info?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/164#issuecomment-334194369, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdSgkb4ljZLQxhD84hNog_01UkL8AJFks5so6RLgaJpZM4POoGg .

rbooth200 commented 6 years ago

So that's the analytical solution script that is failing. Try increasing max_step in the integrator to 10k or something.

giovanni-rosotti commented 6 years ago

ok, in this way it works. i'll push the modification

On Wed, Oct 4, 2017 at 4:36 PM, Richard Booth notifications@github.com wrote:

So that's the analytical solution script that is failing. Try increasing max_step in the integrator to 10k or something.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/pull/164#issuecomment-334196808, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdSgoShefDrAlvie9nTFd8lDEkLKU53ks5so6X4gaJpZM4POoGg .

giovanni-rosotti commented 6 years ago

done, for me this pull request is now fine. david, it is up to you to accept it now