search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
46 stars 12 forks source link

Meshless gravity fix #173

Closed rbooth200 closed 7 years ago

rbooth200 commented 7 years ago

This pull request fixes some errors relating to the meshless and self-gravity with the gadget mac. Before these changes atree was being zero'd in the initializaiton resulting in a brute-force gravity calculation.

There was also a mistake for the imported cells, which has been fixed: we were trying to recompute the acceleration tolerance, amin, for imported cells, which does not work because atree is zerod.

dhubber commented 7 years ago

Seems fine. I guess this is all independent of the other Mfv/radws/eos pull requests so I can merge now?

rbooth200 commented 7 years ago

yes

giovanni-rosotti commented 7 years ago

I am happy for this to be merged. I assume that the bug with brute force was only affecting the first step anyway?

rbooth200 commented 7 years ago

Yeah, I think so. I've got some simulations with the gadget mac running fine at the moment. They are certainly faster than brute force.