search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Problems with ghosts #35

Closed rbooth200 closed 8 years ago

rbooth200 commented 8 years ago

There is currently an issue with the ghosts, which can be verified by running the adsod test with the boundaries set to mirror, resulting in a large force error at the boundaries. This is partially fixed in the dust branch. Also, the CopyDataToGhosts does not cater for reflections of reflections, or properly reflect the velocities

rbooth200 commented 8 years ago

The CopyDataToGhosts function has been fixed regarding reflecting the velocities in the ghosts The shock tests are still producing errors though.

rbooth200 commented 8 years ago

This issue is fixed in the dust branch (commit 6f80912..fc1b0b7) by using the unified interface for force calculations rather than separate methods for periodic/non periodic simulations. Without this interface the mirror boundaries should be consider broken in the master until the dust branch is merged in.

rbooth200 commented 8 years ago

Fixed in dust branch to be merged with master