search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Installing the code #43

Closed giovanni-rosotti closed 8 years ago

giovanni-rosotti commented 8 years ago

I added the setup.py file which allows one to install gandalf in a system folder (and yes, if you do that your folder doesn't need to be called "gandalf" anymore!). I also added two new targets to the makefile - install and installpython. The latter just executes setup.py. The first one instead just copies the gandalf executable to /usr/local/bin (which normally is already in the PATH). There's probably a better way of doing it, but it should work...

rbooth200 commented 8 years ago

This sounds fine to me. I slightly object to installing a simulation code into system directories, but it doesn't make it the wrong thing to do

giovanni-rosotti commented 8 years ago

I've updated also the documentation relative to this problem. I think it should now be ready to be merged

dhubber commented 8 years ago

Okay, I just tried it out and works fine for me also (both python and executable builds). As long as it's not the default make option, and it requires root access (which it does), then I'm fine with it.

rbooth200 commented 8 years ago

When I tried it, it also worked fine. I think it might be worth adding a discussion about using .pydistutils.cfg to specify the install location etc.