search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Added check to kill the simulation when smoothing length is too large… #58

Closed rbooth200 closed 8 years ago

rbooth200 commented 8 years ago

… - only if periodic/reflecting boundaries are used.

I've tested it by varying the number of neighbours in a sod shock tube test. It seems to work fine. Not tested with MPI.

rbooth200 commented 8 years ago

Fixed the compile bug with mpi. Ran a couple more sod tests with mpi, results seem sensible.

giovanni-rosotti commented 8 years ago

It seems fine to me. David, do you want to add it also to the meshless?

dhubber commented 8 years ago

Yes, I can do this (add to the meshless) before we accept the merge. I will do it in a few days after my first lecture.

rbooth200 commented 8 years ago

I've added this to the meshless now since I needed to make a modification the SPH implementation anyway - the condition wasn't yet strict enough to cover all edge cases