search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Additional arguments in gandalf_interpreter.py #6

Closed dhubber closed 10 years ago

dhubber commented 10 years ago

gandalf_interpreter.py doesn't appear to accept additional arguments. Instead, it complains that they are strings (e.g. if argument is supposed to be integer, real etc..)

giovanni-rosotti commented 10 years ago

I just commited (c9a8e8b9fb) a fix for this. Let me know if it works, I tested it on the parameters I could think of and it seemed to work. When you have tested it, we can then close the issue

dhubber commented 10 years ago

Still giving some problems. I tried a few examples (e.g. render x y rho res=256) and it didn't accept that. However it accepts floats for some commands (e.g. limit x -0.005 0.005). Also, I noticed that in many (maybe all) case, it computes the first additional argument correctly but cannot compute any additional arguments giving an error of come kind. Not sure if this means I am getting errors particular to my laptop OS + python set-up though.

giovanni-rosotti commented 10 years ago

Should now be fixed.. give it a try and let me know.

On Wed, Oct 23, 2013 at 11:26 AM, dhubber notifications@github.com wrote:

Still giving some problems. I tried a few examples (e.g. render x y rho res=256) and it didn't accept that. However it accepts floats for some commands (e.g. limit x -0.005 0.005). Also, I noticed that in many (maybe all) case, it computes the first additional argument correctly but cannot compute any additional arguments giving an error of come kind. Not sure if this means I am getting errors particular to my laptop OS + python set-up though.

— Reply to this email directly or view it on GitHubhttps://github.com/gandalfcode/gandalf/issues/6#issuecomment-26891196 .

giovanni-rosotti commented 10 years ago

I mean, both the 'res' keyword (which had a bug in itself) and the handling of more than one keyword argument (which was also buggy)

On Wed, Oct 23, 2013 at 12:15 PM, giovanni rosotti < giovanni.rosotti@gmail.com> wrote:

Should now be fixed.. give it a try and let me know.

On Wed, Oct 23, 2013 at 11:26 AM, dhubber notifications@github.comwrote:

Still giving some problems. I tried a few examples (e.g. render x y rho res=256) and it didn't accept that. However it accepts floats for some commands (e.g. limit x -0.005 0.005). Also, I noticed that in many (maybe all) case, it computes the first additional argument correctly but cannot compute any additional arguments giving an error of come kind. Not sure if this means I am getting errors particular to my laptop OS + python set-up though.

— Reply to this email directly or view it on GitHubhttps://github.com/gandalfcode/gandalf/issues/6#issuecomment-26891196 .

dhubber commented 10 years ago

Yes, I just tried it and it seems to work fine now on the same simulations I tried earlier. So unless you're aware of some other problem, I think we can close this thread.

giovanni-rosotti commented 10 years ago

Good. Let's leave it open for a while just in case some other problem pops out, and then I'll close it

On Wed, Oct 23, 2013 at 12:23 PM, dhubber notifications@github.com wrote:

Yes, I just tried it and it seems to work fine now on the same simulations I tried earlier. So unless you're aware of some other problem, I think we can close this thread.

— Reply to this email directly or view it on GitHubhttps://github.com/gandalfcode/gandalf/issues/6#issuecomment-26894282 .