search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Circular Dependency in Analysis #65

Closed ajw278 closed 7 years ago

ajw278 commented 8 years ago

Small issue in the analysis Python code (mine is an old version but appears to still be there):

data_fetcher.py ---imports--> facade (SimBuffer) --imports--> commandsource --imports--> data_fetcher (UserQuantity)

I solved by moving the SimBuffer import (in data_fetcher.py) and data_fetcher import (in commandsource.py) to the bottom of the respective files.

giovanni-rosotti commented 7 years ago

Sorry Andrew - had missed this completely. I think if you first import facade and then data_fetcher everything should be fine, can you please confirm?

giovanni-rosotti commented 7 years ago

This seems to have solved the problem - closing the issue