search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

kernfac #88

Closed rbooth200 closed 7 years ago

rbooth200 commented 7 years ago

What is kernfac? It is always set to 1.0 so why do we have it? I'm inclined to get rid of it since it is one of many ways in which we destroy encapsulation.

dhubber commented 7 years ago

It is a relic from the deleted Godunov Sph implementation. Basically it had some weird kernel convolution that meant you needed to search for root-2 times the normal kernel extent. So kernfac was 1 for Sph and root-2 for Godunov Sph. Short story is, yes, it can be purged from existence now :-)

On Saturday, 8 October 2016, Richard Booth notifications@github.com wrote:

What is kernfac? It is always set to 1.0 so why do we have it? I'm inclined to get rid of it since it is one of many ways in which we destroy encapsulation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gandalfcode/gandalf/issues/88, or mute the thread https://github.com/notifications/unsubscribe-auth/AEsg1ShzlerXzJN_Eqk8C6duq5sIH7nqks5qx6DigaJpZM4KRugg .

rbooth200 commented 7 years ago

Done.