search

gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Timing #89

Closed rbooth200 closed 7 years ago

rbooth200 commented 7 years ago

This branch contains a huge number of changes, which I now believe to be working. They fall into two categorties 1) Refactoring to remove the TreeCell template dependency 2) Refactoring CodeTiming to make it work with MPI and safer to use in general.

You'll see that there are a few other things ended up in here along the way unfortunately.

dhubber commented 7 years ago

ok, just had a quick review of that branch. Most of the changes seem fine, in particular the timing, box and gravity tree changes although there's a hell of a lot of code changes so couldn't check everything. Some parts I wasn't completely sure what was going on (such as the append/unpack bytes routines) but I'll trust that it is a necessary improvement. Maybe the only thing I will say is that some of these new functions/classes need some comments (like in the standard class or function header styles we've tried to use) since in some cases it is not (immediately) clear to me its purpose otherwise. I will have a look at some other parts now and run a few tests just to check it compiles and runs fine on my machine.

rbooth200 commented 7 years ago

I'll try to find and add the missing class/function descriptions tomorrow. The add bytes/unpack stuff is a horrible hack, but its basically unavoidable and I did it to reduce the need for book keeping as much as possible.

Otherwise the code in hydro tree was about moving tree walks into the tree and splitting them up from the neighbour search side of things

rbooth200 commented 7 years ago

Ok, I think I've added all the comments. Can you let me know if there is anything else? Otherwise we were going to hold off the merge til after the mpi_meshless.

rbooth200 commented 7 years ago

This branch should now be good to go...