gandalfcode / gandalf

GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)
GNU General Public License v2.0
44 stars 12 forks source link

Restock pruned tree #95

Closed rbooth200 closed 7 years ago

rbooth200 commented 7 years ago

At the moment it appears that we are not restocking the pruned trees. This surely means they are out of date resulting in the wrong force update.

The best solution is likely to be to export the leaf cells of the pruned trees after restocking and rebuild them locally.

giovanni-rosotti commented 7 years ago

Related to this issue (but less serious), we are also not updating the hs in the tree after h has been recomputed. See discussion in #92 for how to proceed

giovanni-rosotti commented 7 years ago

See #100 . The update of h is no longer a concern because we are restocking the pruned trees after the h calculation - so they will have the right one.

giovanni-rosotti commented 7 years ago

Fixed in #115