search

gandf / slick-rss

The news reader extension for Chromium
MIT License
25 stars 1 forks source link

Feed order is incorrect sometimes #44

Closed Qrox closed 2 years ago

Qrox commented 2 years ago

Some RSS feeds do not include a publication date in the items (example), which is allowed by the specification, but in Slick RSS the order of new items is incorrect for this kind of feeds.

According to the following code,

https://github.com/gandf/slick-rss/blob/15347a84ad88a514ea6ce396f96fc10515bb0804/background.js#L955-L960

The order when there is date information is the time difference between the item date and a reference date, but the order when there is no date information is the reference date. This logic seems wrong to me.

I think it should either use the channel date and, if there is no channel date, the access date for the order, so items without date information can be displayed in the order they are published.

gandf commented 2 years ago

Do you have feed address as example?

Qrox commented 2 years ago

Yes, I included one in the OP, at this link.

gandf commented 2 years ago

I don't have history order saved in database and I can't use it because of updated feed. I can't use the order they are published without history. I think if no date is present, I must use order inside feed.

Thank for this error feedback.

I'm planning it for next update. Currently, I work on refresh optimised/reworked when click on feed and refresh of left menu.

gandf commented 2 years ago

Closed by commit 561a41e