search

gandm / language-babel

ES2017, flow, React JSX and GraphQL grammar and transpilation for ATOM
https://atom.io/packages/language-babel
MIT License
476 stars 83 forks source link

Tab doesn't work when using language-babel #493

Closed adityavm closed 6 years ago

adityavm commented 6 years ago

When using language-babel, the Tab key doesn't work. Here's a GIF of what happens:

tab

The i is to go into vim insert-mode, after which Tab does nothing. Switching to language-javascript makes it work again.

gandm commented 6 years ago

No idea why as handling tabs is done by either Atom or your Vim package - I don't know which Vim you are using. I think you may have some issues with your Atom install. Have you tried it on another device?This package is used by thousands of people. I think Tab not working would be critical and would have been raised by someone else. Given your issues with language-babel I would suggest you switch to language-javascript as that seems to solve your problems.

adityavm commented 6 years ago

Given your issues with language-babel I would suggest you switch to language-javascript as that seems to solve your problems.

If I had to do that I wouldn't be trying to fix these issues. The package adds value, hence I want to make it work.

I've disabled every package (I use just about 10ish), but it still doesn't work. So I can't be sure the issue isn't with language-babel.

adityavm commented 6 years ago

Update I found the offending issue and managed to fix it. language-babel seems to be setting the editor grammar to jsx, which was activating keybindings for emmet, causing Tab to fail.

I've fixed the keybindings now, and will close this issue. Hopefully it'll be useful for someone else in the future.

gandm commented 6 years ago

Glad you fixed it. Yes I set the grammar to source.js.jsx