gandres / pwm

Automatically exported from code.google.com/p/pwm
0 stars 0 forks source link

NMAS login does not timeout #464

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Configure PWM to only use NMAS for reading responses
2. Enter the Forgotten Password module multiple time, but cancel the action 
when the Challenges appear on screen.
3. Watch the active thread count in catalina.out

What is the expected output? What do you see instead?
My expectation is that idle NMAS logins would timeout after 3 minutes (I 
believe this is hard coded server side). I see instead that NMAS threads are 
not released after those 3 minutes. They seem to remain active infinitely 
(until the tomcat server is restarted). This leads to stability issues with a 
high traffic PWM instance.

Relevant part of catalina.out (note the timestamps):

2013-08-28 20:51:25, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=1 activeCount=2
2013-08-28 20:59:10, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=2 activeCount=2
2013-08-28 21:17:00, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=3 activeCount=3
2013-08-28 21:22:51, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=4 activeCount=4
2013-08-28 22:14:52, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=5 activeCount=5
2013-08-29 08:14:56, TRACE, cr.NMASCrOperator, starting NMASSessionMonitor 
thread id=6 activeCount=6

Original issue reported on code.google.com by sebastia...@gmail.com on 29 Aug 2013 at 6:23

GoogleCodeExporter commented 9 years ago
Note, see issue 396 as well. Our NMAS PoC had the same issue, but we manage to 
find a workaround. The only way to force the CR process to stop is to ensure 
that an NPE is thrown from the servlet request. It is kind of ugly, but it 
works ;)

Original comment by sebastia...@gmail.com on 29 Aug 2013 at 10:28

GoogleCodeExporter commented 9 years ago
fixed in revision 606

Original comment by jrivard on 5 Sep 2013 at 7:06