search

ganehag / pyMeterBus

Pure Python implementation of the Meter-Bus (M-Bus EN13757-3) protocol.
BSD 3-Clause "New" or "Revised" License
77 stars 40 forks source link

Is ENUM34 a required dependency? #12

Closed kolucciy closed 5 years ago

kolucciy commented 5 years ago

I'm trying to use pyMeterBus for Home Assistant integration. https://developers.home-assistant.io/docs/en/creating_integration_manifest.html

However I get the following error when I try to run the component:

[homeassistant.util.package] Unable to install package enum34==1000000000.0.0: Could not find a version that satisfies the requirement enum34==1000000000.0.0 (from -c /home/mikhail/work/home-assistant/homeassistant/package_constraints.txt (line 22)) (from versions: 0.9, 0.9.1, 0.9.11, 0.9.12, 0.9.13, 0.9.14, 0.9.15, 0.9.16, 0.9.17, 0.9.18, 0.9.19, 0.9.20, 0.9.21, 0.9.22, 0.9.23, 1.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.1.5, 1.1.6)

I can also see in the configuration file of home assistant there is:

# Breaks Python 3.6 and is not needed for our supported Python versions
enum34==1000000000.0.0

Was wondering if that can be removed from requirements.txt

ganehag commented 5 years ago

Only for < Python 3.4.

I've fixed it in both requirements.txt and setup.py. Release v0.7.15 should not require these dependencies for newer Python versions any longer.