search

ganehag / pyMeterBus

Pure Python implementation of the Meter-Bus (M-Bus EN13757-3) protocol.
BSD 3-Clause "New" or "Revised" License
74 stars 41 forks source link

Fixed requirements.txt #24

Closed bmxp closed 1 year ago

bmxp commented 1 year ago

Hi there,

within requirements.txt there are some fixed modules like

pycryptodome==3.7.3
pyserial==3.4

Since we have Python 3.9 / 3.10 currently and some libs have been updated may it be possible to limit these to be newer then required like 

pycryptodome>=3.7.3
pyserial>=3.4
ganehag commented 1 year ago

Hi, and thanks for the comment.

The reason I prefer to have a pinned version is that one never knows what breakage a newer version might hold. I've updated all dependencies to the latest version and ensured that the tests are still successful.

bmxp commented 1 year ago

Thank you for your lightning fast changes!

For your background: I have a Smartmeter with mbus connector and want to read out the data into an Application SmartHomeNG. If it works fine, I would create a Plugin for this software and this will likely have requirements that might differ from package to package.

Maybe you could make an update on Pypi, too?

bmxp commented 1 year ago

Update was already placed on pypi.org as 0.8.3. I just did not get it that time.

Thank you very much!