ganesansays / python-twitter

Automatically exported from code.google.com/p/python-twitter
Apache License 2.0
0 stars 0 forks source link

[PATCH] Geo/Location/Place/Bounding Box Parsing Support and HTML Error Response Handling #174

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,

I've spent a bunch of time cleaning up something in the library to handle 
parsing of the geographic info that comes from both the status updates. 
Attached is a patch with the neccesary objects (close to the coding style used 
so far). 

I've also noticed that there a few error responses in HTML (e.g., over capacity 
errors) that are not handle properly (issue 166). I've added changes to handle 
that throughout the doc. Those lines contain original code in comments so that 
it can be verified. 

Thanks,

adam

Original issue reported on code.google.com by adam.a...@gmail.com on 8 Nov 2010 at 8:36

Attachments:

GoogleCodeExporter commented 9 years ago
sorry, forgot to add the new fields to the constructur (doh!). The patch below 
has that fixed.

Original comment by adam.a...@gmail.com on 8 Nov 2010 at 8:57

Attachments:

GoogleCodeExporter commented 9 years ago
adam,

I'm applying the basic geo/places part of the patch to the status class as that 
is new information and easy for me to slide in right before 0.8 release.

I'm not applying the part of the patch that adds Geo and Place classes because 
that is just too new for me to feel comfortable adding right now.  The code is 
also not quite in the style of the current classes so I would have to do some 
large edits to make it fit and I might break code.

I'll be closing this bug with the commit, could you be kind enough to open a 
new issue with the Geo/Place class code and I'll add that after 0.8

thanks!

Original comment by bear42 on 14 Nov 2010 at 6:40

GoogleCodeExporter commented 9 years ago
changes applied in changeset 220:b105d4914738

Original comment by bear42 on 14 Nov 2010 at 6:54