Crash when asset not found

ganeshh123 / notion-pdf-export

A tool to allow batch PDF export for free Notion users. You can export as HTML and then use this tool to convert those into PDFs.

https://app.gn3.sh/notion-pdf-export/

MIT License

427 stars 27 forks source link

Crash when asset not found #14

Closed ganeshh123 closed 4 years ago

ganeshh123 commented 4 years ago

The tool crashes when an asset referenced from a HTML file can't be found. This can either be a local file or an online resource. Maybe this can be fixed with some command line options for wkhtmltopdf to ignore or skip these files.

ganeshh123 commented 4 years ago

Some temporary workarounds:

Delete the HTML file and export this manually using Notion's export tools
Edit the HTML file manually to remove reference to the missing file
If it's a local file, place the file correctly at the correct location

ganeshh123 commented 4 years ago

Fixed in #16

Surrounded the command execution with a try/catch block which moves to the next file and outputs an error message. Issue mostly only occurs with favicon, rest of the document seem to be converted okay.