search

ganeshkbhat / fastprimenumbers

Fastest Prime Number Calculations
Other
4 stars 0 forks source link

False negatives #1

Open programmeruser2 opened 1 year ago

programmeruser2 commented 1 year ago

The algorithm seems to report that 336609055612707510784871435262931004779 is not a prime number, but it is actually one (confirmed with many different sources).

ganeshkbhat commented 1 year ago

Let me check that 336609055612707510784871435262931004779. I probably think that is because of Number.MAX_SAFE_INTEGER of Javascript. MAX_SAFE_INTEGER: 9007199254740991 or Max Value (Number.MAX_VALUE): 2^1024 - 1, or approximately 1.7976931348623157E+308.

The code is not aligned to handle very big or long values; using javascript max values of Number as the base. Let me check if I can accomodate big numbers to assist calculation.

I am keeping this issue open meanwhile.

programmeruser2 commented 1 year ago

Let me check that 336609055612707510784871435262931004779. I probably think that is because of Number.MAX_SAFE_INTEGER of Javascript. MAX_SAFE_INTEGER: 9007199254740991 or Max Value (Number.MAX_VALUE): 2^1024 - 1, or approximately 1.7976931348623157E+308.

I can reproduce this with Python 3, which does not have a default integer limit.

ganeshkbhat commented 1 year ago

Let me check. I will also check on the BigInt and update the code which just got released in Nodejs as well. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt . Any idea when BigInt was released into V8 Nodejs and browser js? The docs say 2018-06-06 from version v10.4.0

Can you share what all tests you are running?

programmeruser2 commented 1 year ago

I don't recall what other tests I used, this was a long time ago. Also, this occurred on Python, not on the JS version.