ganeshrvel / openmtp

OpenMTP - Advanced Android File Transfer Application for macOS
https://openmtp.ganeshrvel.com
MIT License
3.58k stars 134 forks source link

Illegal character confusion/bad ux #365

Open l300lvl opened 4 months ago

l300lvl commented 4 months ago

Not necessarily a bug but this one had me stumped several times. To reproduce this:

Try to copy any file with other files as a group transfer with a quote symbol in the filename of any of the files and the transfer dialog simply pauses and never completes, with no visible warning or error. It just seems to hang eternally.

The way I did detect what is happening is by copying a single file with the bad character, when transferring only one file an illegal character notice is indeed given. When transferring multiple files some good/some with the illegal char, no notice ever came up.

To be sure, I renamed the file after getting the notice, and it indeed copied.

What really really boggles my mind is: if I compress a file containing the illegal character and transfer the zip and extract it under the phone, the character exists just fine? Is it really so illegal?