search

ganesshkumar / obsidian-table-editor

An Obsidian plugin to provide an editor for Markdown tables. It can open CSV data and data from Microsoft Excel, Google Sheets, Apple Numbers and LibreOffice Calc as Markdown tables from Obsidian Markdown editor.
MIT License
216 stars 15 forks source link

[BUG] Create a New Table - Version 0.1.2 #12

Closed FelipeRearden closed 2 years ago

FelipeRearden commented 2 years ago

Describe the bug when creating a new table using the commands Open Editor Below and Open Editor Next the MTE window opens empty :(

To Reproduce On an Active Note

  1. Go to a empty line
  2. Select one of the two commands : Open Editor Below or Open Editor Next
  3. See error (images 1 and 2)

Screenshots 50 51

Desktop (please complete the following information):

Additional context Sorry for bring problems @ganesshkumar !!!!

Let me know if you need more information

FelipeRearden commented 2 years ago

Update from Version 0.1.2

This issue is not working prefect on version 0.1.2 !

Follow the same steps from before the MTE window is ready for the user input ....

There is only one new message box

50

For me it's 100% okay but, as I said before, I think I should tell you about my experience with the new version and you decide the best path :)

Thank you very much !!!!!!!!!!!

ganesshkumar commented 2 years ago

@FelipeRearden , as of this what we are seeing in the v0.1.2 (where there are two rows with one column each) is the expected behavior. Let me know what kind of table you are expecting when you have the cursor on an empty line and opening MTE.

FelipeRearden commented 2 years ago

Hello @ganesshkumar !!!!

@FelipeRearden , as of this what we are seeing in the v0.1.2 (where there are two rows with one column each) is the expected behavior.

100% is okay !!!

Let me know what kind of table you are expecting when you have the cursor on an empty line and opening MTE.

My only observation was that we have the numbers

Row : 3 Columns : 3

But a table with 1x1 for new tables.

Feel free to close this Issue :)

Have a great day !

ganesshkumar commented 2 years ago

I have pushed some changes into 0.3.0. Can you please check and let me know if this works for you?

FelipeRearden commented 2 years ago

I have pushed some changes into 0.3.0. Can you please check and let me know if this works for you?

Hello again @ganesshkumar !!!!

I have two comments related to this FR from my tests on version 0.3.0

Settings

Working perfect, this is the best solution :)

Now I can choose my standard table size. Thank you :)

Bug

I think I found a Bug

With the caret cursor placed in the Rows or Columns field:

⏩ When we hit backspace to clear the field before type another number, we have this is input

image

⏩ To be able to define a new number, I have to place the caret in the before the first letter N then hit 5 for example

Let me know if you want me to create a new issue for this :)

Have a great day!