[BUG]Update table button seems buggy

ganesshkumar / obsidian-table-editor

An Obsidian plugin to provide an editor for Markdown tables. It can open CSV data and data from Microsoft Excel, Google Sheets, Apple Numbers and LibreOffice Calc as Markdown tables from Obsidian Markdown editor.

MIT License

216 stars 15 forks source link

[BUG]Update table button seems buggy #25

Closed jiewangjs closed 2 years ago

jiewangjs commented 2 years ago

When the update table button clicked, it flushes out all the contexts of the current note, leaving only the table.

ganesshkumar commented 2 years ago

@jiewangjs, which version are you using?

jiewangjs commented 2 years ago

latest. i install it freshed a few days ago.

	@.***

@.*** |

---- 回复的原邮件 ---- | 发件人 | Ganessh @.> | | 日期 | 2022年05月02日 09:51 | | 收件人 | @.> | | 抄送至 | @.**@.> | | 主题 | Re: [ganesshkumar/obsidian-table-editor] [BUG]Update table button seems buggy (Issue #25) |

@jiewangjs, which version are you using?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

emisjerry commented 2 years ago

If there's no line breaks between header and table, after updating table, the ## 10. Headings will be lost.

## 10. Headings
| Left aligned text | Centered text |  Right aligned text |
|:------------------|:--------------|:--------------------|
| Cell1             | Cell1         | Cell1               |
| Cell2             | Cell2         | Cell2               |
| Cell3             | Cell3         | Cell3               |

ganesshkumar commented 2 years ago

Need to support no line breaks before the table.

Edit: spelling

ganesshkumar commented 2 years ago

Can you check and confirm this in the latest version?

hihihlo commented 1 year ago

about "Update Table" button, this bug still exist. (my version is 0.3.1)

case 1: as @emisjerry said, the Headings will be lost. case 2: I use custom Q/A format within plugin "Obsidian-to-Anki", it mark Answer("A:") end by empty line, so I can't add empty line before/after table. below is a valid Q/A pair

Q: this is a test question
A:    
some prefix description
| hdr-1 | hdr-2 |
|:----- |:----- |
| aa1   | aa2   |
| bb1   | bb2    |
- some postfix description

if I press "Update Table" button, every thing disappear except markdown table !

is it possible to fix the bug ?

RedLilith commented 1 year ago

I just tried updating a table in one of my notes leaving a 3 empty spaces above it, and all of my note still disappeared. My obsidian version: 1.3.5, plugin version: 0.3.1, on Win 11 OS