Closed dg1223 closed 8 months ago
Your analysis to find the syntax error looks perfectly correct. I am confused by why that did not work. Are few potential pitfalls:
pip install ganga
and at the same time checked out ganga from GitHub, you may well have two instances of the code and edit the wrong one.If you make a pull request with the suggested change above, I am happy to test it.
Thanks for the hints! I created new jobs every time but I think I checked out ganga from GitHub as well as pip installed ganga at the same time. I'll rerun the tests and confirm tomorrow.
So, I was indeed running pip install ganga
but making changes locally :)
Installed Ganga from source and tested the fix. It worked. Opened a PR #2301
Here's how to reproduce the issue. I have Ganga installed inside a virtual environment called
gangaenv
.Activate Ganga
Run a Ganga job inside a Docker container
Here's the error that I get:
I was able to hack the input file that is created by the job locally and successfully run the job. But it doesn't solve the core issue. Here's how I did it:
Open
/home/[your_linux_username]/gangadir/workspace/[your_linux_username]/LocalXML/[job_number]/input/__jobscript__
Go to line 230
Add a space and an escape character
\
after the+
sign.Go to line 253
Repeat step 3
Save file
Force job status to fail →
j..force_status('failed')
Resubmit job →
j.resubmit()
Seems to solve the issue.
I believe I found the main script Docker.py that is causing this error. However, applying the same fix on the script doesn't resolve the issue. I tried digging further to see how the script is called but couldn't figure it out in a short period. I tried to apply the following fix:
ganga/GangaCore/Lib/Virtualization/Docker.py
\
after the+
sign.\
after the+
sign.I might be able to solve this issue if I get some guidance from someone who's experienced with the codebase (or if I invest a lot more time :) )