search

ganga-devs / ganga

Ganga is an easy-to-use frontend for job definition and management
GNU General Public License v3.0
99 stars 159 forks source link

#2299: Fixed a syntax error that occurs while running a ganga job using Docker #2301

Closed dg1223 closed 6 months ago

dg1223 commented 6 months ago

Adding an escape character to each of the execmd lines (81 and 104) in Docker.py seems to solve the issue.

Visible changes on line 230 in the resulting input file (/home/[your_linux_username]/gangadir/workspace/[your_linux_username]/LocalXML/[job_number]/input/__jobscript__) after the job is submitted:

Before the fix

execmd = ['docker', 'run', '--rm', '-v', workdir+":"+"/work_dir"] +
             options + [virtualization_image] + execmd

After the fix execmd = ['docker', 'run', '--rm', '-v', workdir+":"+"/work_dir"] + options + [virtualization_image] + execmd

Similar change in line 253.

Passed all unit tests.

dg1223 commented 6 months ago

Thanks for fixing this syntax error.

No problem!