search

ganga-devs / ganga

Ganga is an easy-to-use frontend for job definition and management
GNU General Public License v3.0
100 stars 159 forks source link

fix issues with some malfunctioning docker commands (#2309) #2314

Closed dg1223 closed 7 months ago

dg1223 commented 7 months ago

The following Docker commands now work correctly:

d = Docker()
d = Docker('fedora:latest')
d = Docker(image='fedora:latest')
d = Docker(image='fedora:latest', mode='P1')

In addition, added unit tests for each of these commands.

Please note that this fix does not remove the __init__ function from Docker,py as suggested here. Instead, it sets default values for the image and mode parameters in the __init__ function in Docker.py.

egede commented 7 months ago

@dg1223 Thanks for adding the test cases as well.

dg1223 commented 7 months ago

@dg1223 Thanks for adding the test cases as well.

No problem at all!