Avoid filter_input for compatibility with PHP < 5.2.

ganglia / ganglia-web

Ganglia Web Frontend

BSD 3-Clause "New" or "Revised" License

316 stars 170 forks source link

Avoid filter_input for compatibility with PHP < 5.2. #230

Closed johntconklin closed 5 years ago

johntconklin commented 10 years ago

This change avoids filter_input(), for systems with older PHP versions like RHEL/Centos 5.X.

vvuksan commented 10 years ago

Question is how many systems these days use PHP < 5.2. Anything less than 5.3 or even perhaps 5.4 has unpatched security issues. I am not convinced this should be merged.

johntconklin commented 10 years ago

Some arguments for integrating the change:

With this patch, ganglia-web works as expected. Without it, it silently fails with an empty page when it reloads automatically or when menu choices are selected.
Of all the places URL parameters are read, these two instances are the only ones that use filter_input().
If ganglia-web is to require a minimum version of PHP, it needs to be documented and it should be explicitly caught in index.php instead of having things "almost work" and having end users have to track down why it doesn't...
The current version of PHP on RHEL/Centos 5.X is 5.1.6; and in my experience the use of RHEL/Centos 5.X is still quite common in corporate/enterprise environments.

afbjorklund commented 8 years ago

It should be compatible with RHEL 6 and php 5.3.3 now, there is a Travis test for it: 5a38f6a9da580514fc86546d6058992ace81e59a (php 5.3: https://travis-ci.org/ganglia/ganglia-web/jobs/138576759)

If Travis supports even older versions, then maybe we could test for 5.1.6 as well ? And I also think that these two isolated uses of filter_input look odd, anyway.

afbjorklund commented 8 years ago

Nope, there is no Travis support for php 5.1 - maybe it is time to upgrade (to "php53") ? https://travis-ci.org/ganglia/ganglia-web/jobs/143943691

vvuksan commented 5 years ago

Closing this as it's very old.