search

ganglia / ganglia-web

Ganglia Web Frontend
BSD 3-Clause "New" or "Revised" License
316 stars 168 forks source link

Removed unused code, and fixed remaining code for initializing the list #294

Closed pcpiela closed 8 years ago

pcpiela commented 8 years ago

of available metrics.

vvuksan commented 8 years ago

Are you sure availablemetrics is not being used ?

pcpiela commented 8 years ago

I cannot see where it is used, and my testing seems to confirm that. I will take another look tomorrow. We have gone through several mechanisms for selecting metrics with the current initializing the list using harmless options. I am a bit rusty on the code base, so I don't rule out a goof on my part.

Peter

Sent from my iPhone

On Jul 18, 2016, at 9:57 PM, Vladimir Vuksan notifications@github.com wrote:

Are you sure availablemetrics is not being used ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

pcpiela commented 8 years ago

Vladimir, I confirmed that availablemetrics is no longer required with the new metric selection widget. This is not true for breakdown_reports and cubism that use a modified input widget.

Peter

Sent from my iPhone

On Jul 18, 2016, at 9:57 PM, Vladimir Vuksan notifications@github.com wrote:

Are you sure availablemetrics is not being used ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.