Closed jtfrey closed 8 years ago
There appears to be a conflict with the current master. Can you fix this and resubmit. Thanks
The conflict is that someone deleted a trailing space on line 318...do you really need me to redo everything for that?
Merged upstream changes into my fork and reapplied my patch. Please try now.
We noted rrdtool crashing when an invalid clustername is passed to ganglia-web (e.g. ?c=not_our_cluster). While the segfault is due to a bug we isolated in rrdtool when using the caching daemon, it seems appropriate for ganglia-web to check the "c" CGI parameter to ensure it's a defined cluster. As it stands, this code change simply ensures the find_avg() function doesn't pass any non-existent files to rrdtool. The check for a valid cluster name should probably be implemented at a higher level, though, which might make the existence of the directory/file a valid precondition to find_avg() and negate this patch.