Closed ranacseruet closed 10 years ago
Rana, Github says there is a merge conflict. Can you provide an additional commit on your branch to resolve the merge conflict? Maybe somebody else has change one of the files while you were waiting for this to be accepted.
Thanks Daniel. I have merged with the master branch and seems now it can be merged automatically.
@ranacseruet This is good - I didn't realize we were missing this many metrics!
Would you please explain why you removed the power_man_mode
and perf_state
metrics? Those metrics seem to be working fine on our systems.
@eshelman , thanks for reviewing! Actually most of the new metrics are from taken from new NVML version.
To answer your question, I have removed those metrics based on suggestion/discussion with my mentor Rajat Phull(rphull@nvidia.com). The reasons are given below:
power_man_mode
: For the current generation and some of the recent generations of GPUs, the Power management module is always available on the devices. So we thought to turn it off. If needed by community, we can enable this.
perf_state
: We thought that looking at current clocks gives a better representation of the performance state, and giving pstate in constant/host section may not add a lot of value. But again, if community needs it, we will get it back.
Thanks for the details! Your explanation makes sense - these changes wouldn't be a problem for us.
That's great then. Thanks!
Thanks for this contribution Rana
Metrics Added:
Metrics Modified:
Metrics Deleted:
Custom Graph Modifications: